This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: java patch: read compressed archives on Alpha
- To: "green at cygnus dot com" <green at cygnus dot com>
- Subject: Re: java patch: read compressed archives on Alpha
- From: Andreas Jaeger <aj at suse dot de>
- Date: 10 Dec 2000 16:30:05 +0100
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>,"apbianco at cygnus dot com" <apbianco at cygnus dot com>
- References: <01C06279.F421E200.green@redhat.com>
>>>>> Anthony Green writes:
> On Sunday, December 10, 2000 3:53 AM, Andreas Jaeger [SMTP:aj@suse.de] wrote:
>> This implies that files will have a size of less than 2 GB. Is this
>> really desired?
> I'm sorry, I don't see how my change does that. Could you please explain?
I didn't check the whole file and just looked at the patch. It might
be that I'm wrong but for my eye it looked as if I'm right (ok,
substitute 4 GB by 2 GB).
Your patch uses:
+ unsigned size; /* length of file */
+ unsigned uncompressed_size; /* length of uncompressed data */
+ unsigned filestart; /* start of file in archive */
Since "size" will now only have 32bits, a single file in the directory
has a length of at most 4 GB. Together with filestart this means that
it can be at most 4 GB away from the beginning of the zip file.
Did I miss anything?
Andreas
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.inka.de
http://www.suse.de/~aj