This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [C++ PATCH] exception specifiers for implicit members


>>>>> "Nathan" == Nathan Sidwell <nathan@codesourcery.com> writes:

> This patch will lead to additional code size, as we will generate the
> exception specification checking code for these functions -- even though
> it is guaranteed that they won't be violated.

I'm surprised by this; there are very few exception specs in v3, and the
TREE_NOTHROW stuff should do away with the checking code in synthesized
functions.  Any idea why it doesn't?  Or a testcase?

> + /* Use EXTRACTOR to locate the relevant function called for each base &
> +    class field of TYPE. QUALS allows cv quals to be passed to EXTRACTOR.
> +    Generates the union of all exceptions generated by those functions.  */

This comment is out of date; QUALS is now CLIENT.  I find this special
callback rather baroque, but I'm not coming up with a better solution, so I
guess it's OK.

> + tree
> + merge_exception_specifiers (list, add)

This function needs a comment.

Jason

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]