Re: cpplib: More interface cleanups

[Franz Sirl <Franz dot Sirl-kernel at lauterbach dot com>]

At 21:49 28.11.00, Neil Booth wrote:
>This combines cpp_init() and cpp_reader_init() into
>cpp_create_reader() for a slightly simpler, better interface, and
>updates all affected code.
>
>This is some more work towards reducing the interface exposed in
>cpplib.h and reducing implementation assumptions clients can make.  In
>particular I want to make the cpp_reader structure opaque.
>
>Bootstrapped x86 Linux.
>
>Neil.
>
>         * c-lex.h (parse_in): Change parse_in to a cpp_reader *.
>         * c-decl.c (c_decode_option): Update to match.
>         * c-lex.c (init_c_lex, yyparse): Update to match.
>         * c-lang.c (lang_init_options): Use cpp_create_reader.
>         * cppinit.c (cpp_init): Rename initialize.
>         (cpp_reader_init): Rename cpp_create_reader.  Create the
>         reader.  Initialize cpplib if appropriate.
>         * cpplib.h (cpp_create_reader) New prototype.
>         (cpp_init, cpp_reader_init): Delete prototypes.
>         * cppmain.c (general_init, setup_callbacks): New functions.
>         (main): Use them.
>         * fix-header.c (scan_in): Change type to cpp_reader *.
>         (read_scan_file): Update for new cpplib interface and scan_in type.
>
>         * cp/decl.c (parse_in): Change to cpp_reader *.
>         (lang_decode_option): Update.
>         * cp/lex.c (lang_init_options): Use new cpplib interface.
>         (init_cp_pragma, finish_parse, handle_pragma_implementation): Update.
>         * cp/spew.c (read_token): Update.
>         * objc/objc-act.c (lang_init_options): Update new cpplib interface.

Could it be that this patch broke "#pragma weak" support? I now get a few 
more warnings during compile and g++/libstdc++-v3 completely FAIL during 
tests, with error messages related to the pthread* function listed below.

Franz.


./xgcc -B./ -B/home/fsirl/gnubin/ppc-redhat-linux/bin/ -isystem 
/home/fsirl/gnubin/ppc-redhat-linux/include -O2   -DIN_GCC    -W -Wall
-Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -isystem 
./include  -fPIC -g1 -DHAVE_GTHR_DEFAULT -DIN_LIBGCC2 -D__GCC_FLOAT_N
OT_NEEDED  -I. -I. -I/home/fsirl/cvsx/gccm/gcc 
-I/home/fsirl/cvsx/gccm/gcc/. -I/home/fsirl/cvsx/gccm/gcc/config 
-I/home/fsirl/cvsx/gccm
/gcc/../include  -fexceptions -fPIC -mstrict-align -DL_eh -c 
/home/fsirl/cvsx/gccm/gcc/libgcc2.c -o libgcc/./_eh.o
/home/fsirl/cvsx/gccm/gcc/gthr-posix.h:41: warning: ignoring #pragma weak 
pthread_once
/home/fsirl/cvsx/gccm/gcc/gthr-posix.h:41: warning: ignoring #pragma weak 
pthread_key_create
/home/fsirl/cvsx/gccm/gcc/gthr-posix.h:41: warning: ignoring #pragma weak 
pthread_key_delete
/home/fsirl/cvsx/gccm/gcc/gthr-posix.h:41: warning: ignoring #pragma weak 
pthread_getspecific
/home/fsirl/cvsx/gccm/gcc/gthr-posix.h:41: warning: ignoring #pragma weak 
pthread_setspecific
/home/fsirl/cvsx/gccm/gcc/gthr-posix.h:41: warning: ignoring #pragma weak 
pthread_create
/home/fsirl/cvsx/gccm/gcc/gthr-posix.h:41: warning: ignoring #pragma weak 
pthread_mutex_lock
/home/fsirl/cvsx/gccm/gcc/gthr-posix.h:41: warning: ignoring #pragma weak 
pthread_mutex_trylock
/home/fsirl/cvsx/gccm/gcc/gthr-posix.h:41: warning: ignoring #pragma weak 
pthread_mutex_unlock