This is the mail archive of the
mailing list for the GCC project.
Re: [patch] New flag -Wsystem-headers
- To: Benjamin Kosnik <bkoz at redhat dot com>
- Subject: Re: [patch] New flag -Wsystem-headers
- From: Neil Booth <NeilB at earthling dot net>
- Date: Tue, 26 Sep 2000 07:37:02 +0100
- Cc: gcc-patches at gcc dot gnu dot org, branko dot cibej at hermes dot si
- References: <200009252240.e8PMe7r17618@fillmore.constant.com>
Please be more careful when committing - you broke cpplex.c with merge
The patch has caused (I think) two regressions (but you weren't cc-ed
on the mail about regressions). Any ideas?
>With your recent patch, GCC has some regression test failures, which
>used to pass. There are 2 new failures, and 0
>failures that existed before and after that patch; 0 failures
>have been fixed.
>The new failures are:
>gcc/testsuite/gcc.sum:FAIL: gcc.dg/cpp/syshdr.c (test for excess errors)
>gcc/testsuite/gcc.sum:FAIL: gcc.dg/wtr-int-type-1.c decimal constant (test for warnings, line 40)
Benjamin Kosnik wrote:-
>This patch is now in.
>Hopefully, this will make the shadow header work for libstdc++-v3 easier.
>bootstrapped on x86/linux
> 2000-09-25 Branko Cibej <firstname.lastname@example.org>
> * flags.h: Declare warning flag warn_system_headers.
> * toplev.c: Define it.
> (W_options): Add option -Wsystem-headers.
> * diagnostic.c (count_error): Test warn_system_headers.
> * invoke.texi: Add description for -Wsystem-headers.
> * cpplib.h (cpp_options): New member warn_system_headers.
> * cpphash.h (CPP_PEDANTIC, CPP_WTRADITIONAL): Don't test
> * cpplib.c (do_import, do_pragma_once): Likewise.
> * cpperror.c (_cpp_begin_message): Test warn_system_headers
> and CPP_IN_SYSTEM_HEADER.
> * cppinit.c (handle_option): Recognize -Wsystem_headers.
> (print_help): Describe -Wsystem_headers.
> * cpplex.c (lex_line): Reorganize condition so that warnings
> about C++ comments in system headers can be enabled. Remove
> label do_line_comment.