This is the mail archive of the
mailing list for the GCC project.
Re: format checking patch: preliminary cleanup of flags handling
- To: "Joseph S. Myers" <jsm28 at cam dot ac dot uk>
- Subject: Re: format checking patch: preliminary cleanup of flags handling
- From: Jeffrey A Law <law at cygnus dot com>
- Date: Mon, 25 Sep 2000 11:02:05 -0600
- cc: gcc-patches at gcc dot gnu dot org
- Reply-To: law at cygnus dot com
In message <Pine.LNX.firstname.lastname@example.org
> This patch does a preliminary cleanup of how format checking handles
> flags - the flags stored in print_char_table (etc.) are split into
> those relating to flags (or features such as precision) permitted with
> a conversion specifier, and those giving other information about that
> conversion specifier to check_format_info. Additional flags are added
> to those in flags2 to get rid of another two ad hoc conditionals. (A
> future patch will move details of permitted flags and bad combinations
> of flags into tables and get rid of the various bits of ad hoc
> checking for this currently used.)
> Bootstrapped with no regressions on i686-pc-linux-gnu. OK to commit?
> 2000-09-24 Joseph S. Myers <email@example.com>
> * c-common.c (format_char_info): Add flags2; update comments.
> (print_char_table, scan_char_table, time_char_table): Split some
> flags out into flags2.
> (check_format_info): Use flags2 for those flags, for identifying
> the initial character of a scanf scanset, and for identifying
> printf formats where the '0' flag is ignored with precision.
Approved. Please install if you haven't done so already.