This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Tiny speedups..



I think this is a good idea.  You shold use NULL_RTX instead of `0' in
the return values for single_set.

I actually think it's a mistake to spell function-like macros in
ALL_CAPS, precisely because that makes changing back-and-forth unduly
disruptive.  In my opinion, we should only use ALL_CAPS for accessors
and simple predicates.  I don't know what others thing about this.

Is a PARALLEL required to have two instructions?  The documentation
doesn't imply that, but your code will crash if there are zero or one
instructions in the parallel.  Also, the documentation does not
prescribe the order in the PARALLEL that you are relying upon.  I
think that you should update the TeXinfo documentation to reflect this
assumption, if we are going to rely on it.

I'll let Richard (or someone else) make the final call on all this, as
I'm less familiar with the exact details in this area.

Thanks,

--
Mark Mitchell                   mark@codesourcery.com
CodeSourcery, LLC               http://www.codesourcery.com

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]