This is the mail archive of the
mailing list for the GCC project.
Re: Patches not reviewed or integrated
- To: Geoff Keating <geoffk at cygnus dot com>
- Subject: Re: Patches not reviewed or integrated
- From: Stephane Carrez <Stephane dot Carrez at worldnet dot fr>
- Date: Fri, 08 Sep 2000 00:29:08 +0200
- CC: gcc-patches at gcc dot gnu dot org
- References: <39B6CBF1.6B4DDC59@worldnet.fr> <email@example.com>
Geoff Keating a écrit :
> Stephane Carrez <Stephane.Carrez@worldnet.fr> writes:
> > Hi!
> > Any news about the review/integration of the following patches (68hc11 port)?
> > [PATCH]: Unsigned -> float conversion for fp-bit.c
> > http://gcc.gnu.org/ml/gcc-patches/2000-08/msg00290.html
> This patch is OK.
> > [PATCH]: Dump rtl in assembly
> > http://gcc.gnu.org/ml/gcc-patches/2000-08/msg00289.html
> This patch needs to be documented. You need to update
Ok. The man page gcc.1 must be updated too.
I'll resubmit this one with documentation.
> > [PATCH]: libgcc2.h fix to build DI mode operations
> > http://gcc.gnu.org/ml/gcc-patches/2000-08/msg00288.html
> This patch seems OK.
> > [PATCH]: Update gcc.1 man page for 68HCx port.
> > http://gcc.gnu.org/ml/gcc-patches/2000-08/msg00274.html
> This patch is OK, but see my comment below about the texinfo
> > [PATCH]: Recognize 68HC11 & 68HC12 target in gcc
> > http://gcc.gnu.org/ml/gcc-patches/2000-08/msg00273.html
> This patch is OK.
> > [PATCH]: 68HC11 & 68HC12 port (gcc/config/m68hc11)
> > http://gcc.gnu.org/ml/gcc-patches/2000-08/msg00272.html
> This patch is missing documentation. You need to go through the Info
> documentation and add
> - the description of -m options your port uses
> - the special constraints your port has
Ok. I'll do a separate patch for texinfo documentation about the port.
> Also, the very last line of the patch has
> +#define inhibit_libc
> which is not the right way to do whatever it is you want.
There are a number of functions in libgcc2.c that have no sense for 68hc11
and I want to disable them (empty obj file). It does what I want because the
.o are empty for those functions (_eprintf, _bb, ...).
> Otherwise, it looks OK, and could be committed as-is. You should add
> yourself to the MAINTAINERS file as the maintainer of the new port.
> > Thanks for taking some time to have a look at them,
> Do you have a copyright assignment on file? Do you have commit access
> to the tree?
> - Geoffrey Keating <firstname.lastname@example.org>
I have a copyright assignment for Gcc, Gdb and Binutils (assign.future).
Andrew Cagney set up things for gdb so that as maintainer of Gdb-68hc11,
I have write access to a few files in /cvs/src but probably not in /cvs/gcc.
If trees can be set up in the same manner for some files in /cvs/gcc
Thanks a lot for your time,
E-mail: email@example.com Stephane.Carrez@sun.com
WWW: http://home.worldnet.fr/stcarrez http://www.sun.com
Mail: 17, rue Foucher Lepelletier 6, avenue Gustave Eiffel
92130 Issy Les Moulineaux 78182 Saint Quentin en Yvelines