This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: SSA for hard registers
- To: Richard Henderson <rth at cygnus dot com>
- Subject: Re: PATCH: SSA for hard registers
- From: Jeffrey A Law <law at cygnus dot com>
- Date: Mon, 31 Jul 2000 19:26:57 -0600
- cc: Mark Mitchell <mark at codesourcery dot com>, gcc-patches at gcc dot gnu dot org, Jeffrey David Oldham <oldham at codesourcery dot com>
- Reply-To: law at cygnus dot com
In message <20000731175642.A7481@cygnus.com>you write:
> On Mon, Jul 31, 2000 at 10:35:46AM -0700, Mark Mitchell wrote:
> > + /* We cannot use <assert.h> in GCC source, since that would include
> > + GCC's assert.h, which may not be compatible with the host compiler.
> */
> > + #undef assert
> > + #ifdef NDEBUG
> > + # define assert(e)
> > + #else
> > + # define assert(e) do { if (! (e)) abort (); } while (0)
> > + #endif
>
> The entire rest of the source base uses `if (!e) abort()';
> I don't see that we should make an exception here.
Agreed. The standard is to use
if (can't happen)
abort ();
Unless there's a complelling reason I think we should stick with
that coding standard.
jeff