This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] tradcpp include fix
- To: Zack Weinberg <zack at wolery dot cumb dot org>
- Subject: Re: [PATCH] tradcpp include fix
- From: Jakub Jelinek <jakub at redhat dot com>
- Date: Mon, 24 Jul 2000 19:04:22 +0200
- Cc: gcc-patches at gcc dot gnu dot org, notting at redhat dot com, nalin at redhat dot com
- References: <20000724111910.E560@sunsite.ms.mff.cuni.cz> <20000724095641.D21058@wolery.cumb.org>
- Reply-To: Jakub Jelinek <jakub at redhat dot com>
On Mon, Jul 24, 2000 at 09:56:41AM -0700, Zack Weinberg wrote:
> On Mon, Jul 24, 2000 at 11:19:10AM +0200, Jakub Jelinek wrote:
> > Hi!
> >
> > There can be cpp_include_defaults directories longer than
> > cpp_GCC_INCLUDE_DIR_len, e.g. TOOL_INCLUDE_DIR in some configurations.
> > As tradcpp was not updating max_include_len for them and just assumed
> > cpp_GCC_INCLUDE_DIR_len is the longest length, it crashed because alloced
> > area in do_include was not enough.
> > Ok to commit?
>
> Yes, this is fine.
Thanks.
>
> Is this the fix for the crash compiling lilo you told me about last
> week?
Yes, this segfault was reported for memtest, lilo and I assume dosemu as
well (I have just tested the former two and they no longer segfault and work
as expected).
Jakub