This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch for PR gcj/268
- To: tromey at cygnus dot com
- Subject: Re: Patch for PR gcj/268
- From: Alexandre Petit-Bianco <apbianco at cygnus dot com>
- Date: Sun, 25 Jun 2000 11:05:45 -0700 (PDT)
- Cc: Gcc Patch List <gcc-patches at gcc dot gnu dot org>
- References: <871z1lejwj.fsf@creche.i-did-not-set--mail-host-address--so-shoot-me>
- Reply-To: apbianco at redhat dot com
Tom Tromey writes:
> Here is an updated version of my patch for PR gcj/268. I'm still
> not convinced this is the correct patch, and it does feel rather
> hacky to me.
Alternatively, one could build a WFL around it. Something like:
if (TREE_CODE_CLASS (TREE_CODE ($3)) == 'c')
$3 = build_wfl_node ($3)
$$ = finish_for_loop (EXPR_WFL_LINECOL ($3), $3, $5, $7);
> Perhaps it would be better to modify lex.c to only return
> expressions and never constants? I don't know (but I'd be
> interested in finding out).
Yes. The lex.c could encapsulate things in WFLs. But then I think we
would loose the ability to fold RHS like `1+2+3'.
./A