This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [cpplib] implement pragma dependancy


On Fri, Jun 23, 2000 at 02:06:04PM +0100, Nathan Sidwell wrote:
> Zack Weinberg wrote:
> > I like the general idea.  Unfortunately I just rewrote
> > find_include_file() and friends to fix Jakub's bug with "" vs <>
> > includes - so if you can update your patch, after I commit the
> > changes, and resubmit, that would be nice.
> Ok, attached is a modified patch + documentation

This depends on the other patch for pragma namespaces, right?

> I modified the error messages to be either boilerplate, or the trailing
> text, not a mixture. Thus we get,
> 
> foo.c:3:62: warning: rerun fixincludes
> foo.c:4:44: warning: out of date with dependency on "/usr/include/time.h"

"warning: rerun fixincludes" is not a good error message.  It does not
say why, or what the actual problem is.  I think we should always
generate the boilerplate text:

foo.h:3:62: warning: out of date with dependency on "/usr/include/time.h"

and if there's trailing text, emit that as a separate warning:

foo.h:3:62: warning: suggest you rerun fixincludes

Also, "out of date with dependency on" is a tad confusing.  Something
like this might be better:

foo.h:3:62: warning: header is older than "/usr/include/time.h"

Finally, should this pragma be rejected in the primary source file? I
suppose it could be useful for Yacc output files and the like, too.

zw

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]