This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Don't abort in C++ emit_local_var
- To: jakub at redhat dot com
- Subject: Re: [PATCH] Don't abort in C++ emit_local_var
- From: Mark Mitchell <mark at codesourcery dot com>
- Date: Wed, 21 Jun 2000 02:34:13 -0700
- Cc: gcc-patches at gcc dot gnu dot org
- Organization: CodeSourcery, LLC
- References: <20000621113244.Z474@sunsite.ms.mff.cuni.cz>
Jakub --
I'm sort-of unhappy about this patch. It really is odd to have
emit_local_var being called more than once. That assert has turned up
a lot of bugs.
I'm not at all confident that your change is safe. Is there any
guarantee that the stack slots allocated to the local are still valid?
Won't they have been marked as going out of scope by that point?
I think the sibling call stuff should punt if encounters any
DECL_STMTs inside the arguments to the call, instead.
--
Mark Mitchell mark@codesourcery.com
CodeSourcery, LLC http://www.codesourcery.com