This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: A patch for gcc/intl parallel build



H.J. --

Thanks for tracking down the cause of the parallel build problem.

I commited the following simpler patch.  In general, I think it's a
bad idea to lie about dependencies in the Makefiles.  A little more
rebuilding that absolutely necessary is not the end of the world,
whereas failing to rebuild something can lead to the world's hardest
to track down bugs.  If, ultimately, this patch leads to excessive
libintl.a rebuilds, the right thing to do is to explicitly list the
correct dependencies for libintl.a, rather than just depending on
intl.all.

Tested on i686-pc-linux with a 4-way parallel build.

--
Mark Mitchell                   mark@codesourcery.com
CodeSourcery, LLC               http://www.codesourcery.com

2000-06-10  Mark Mitchell  <mark@codesourcery.com>

	* Makefile.in (libintl.a): Depend on intl.all.

Index: Makefile.in
===================================================================
RCS file: /cvs/gcc/egcs/gcc/Makefile.in,v
retrieving revision 1.464
diff -c -p -r1.464 Makefile.in
*** Makefile.in	2000/06/10 01:45:51	1.464
--- Makefile.in	2000/06/11 02:52:48
*************** intl.o: intl.c intl.h gansidecl.h Makefi
*** 1743,1754 ****
  	  -DLOCALEDIR=\"$(localedir)\" \
  	  -c `echo $(srcdir)/intl.c | sed 's,^\./,,'`
  
! # This is needed to when doing a partial build after a `make clean'.
! # libintl.a does not depend on intl.all,
! # as that would force a lot of recompiling.
! $(top_builddir)/intl/libintl.a:
! 	@echo "$(MAKE) intl.all"
! 	@$(MAKE) $(FLAGS_TO_PASS) intl.all
  
  # Make sure all the headers are there for xgettext to scan.
  $(INTL_TARGETS): $(srcdir)/c-gperf.h \
--- 1743,1749 ----
  	  -DLOCALEDIR=\"$(localedir)\" \
  	  -c `echo $(srcdir)/intl.c | sed 's,^\./,,'`
  
! $(top_builddir)/intl/libintl.a: intl.all
  
  # Make sure all the headers are there for xgettext to scan.
  $(INTL_TARGETS): $(srcdir)/c-gperf.h \

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]