This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] C++: Fix three mangling bugs



Chip --

  Thanks for your patch.

	(find_substition): Don't mangle objects with typename
	substitutions (e.g. "cin" as "Si").

  I installed this fix.  Thanks!

	* mangle.c (discriminator_for_local_entity): Don't crash if a
	local class is NULL_TREE.

  This is wrong.  That probably means that a local class is not
getting registered.  You didn't send a test-case which makes it tough
to track this one down.  Please send your test-case to me privately,
and I'll see what's going on.

	Correctly mangle numbers up to max of unsigned HOST_WIDE_INT.

  I'm not keen on your approach here. :-) I don't think `int' needs to
be cast to `HOST_WIDE_INT' everywhere.  Am I missing something?  That
aside, there's definitely a bug in there.  I'll look into fixing this
in a slightly different way.

  Thanks!

--
Mark Mitchell                   mark@codesourcery.com
CodeSourcery, LLC               http://www.codesourcery.com

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]