This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: fixincludes templates cleanup



Hi Zack,

Thanks for removing some more of the outdated stuff.
You removed a tiny bit more than I would like tho:

Zack Weinberg wrote:
> ===================================================================
> Index: fixinc/fixincl.tpl
> --- fixinc/fixincl.tpl  1999/12/29 22:58:06     1.10
> +++ fixinc/fixincl.tpl  2000/01/22 00:52:40

> - *  Description of [=hackname _Cap=] fix
> + *  Description of [=hackname _cap=] fix
>   */
> -#define [=hackname _up #_FIXIDX + #%-32s _printf=] [=_eval _index=]
> -tSCC z[=hackname _cap=]Name[] =
> -     [=hackname _cap _krstr=];
> +[= _IF FIXINC_DEBUG _exist
> +=]#define [=hackname _up #_FIXIDX + #%-32s _printf=] [=_eval _index=]
> +[= _ENDIF
> +=]tSCC z[=hackname _cap=]Name[] =
> +     [=hackname _krstr=];

These #defines exist for the theoretical future time
when some piece of code needs to access the fix description
for a particular fix.  Thus, for example, you could reference:

  fixDescList[ AIX_SYSWAIT_FIXIDX ].p_test_desc[0].p_test_regex

and get the compiled regular expression for the first
application test for the aix_syswait fix.

===

Rather than make it conditional, perhaps instead
add the above couple of paragraphs as AutoGen
comments.  I.e:

  [= #  These #defines exist for ...
  =]#define ...

I notice I misnamed the pointer to an array of test
descriptors.  It should have been:  pa_test_desc

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]