This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Recent libgcc2 changes broken



I don't see how all the recent changes in libgcc2 are supposed to work, there's
something badly broken here.

Previously when we built libgcc2 we would define something like
L_fixunssfsi which would cause the _fixunssfsi routine to be built.

With your new code, the modes used by libgcc2 change based on the word
size of the target.  For example on a 16bit target (mn102) defining
L_fixunssfsi will actually result in a routine called fixunssfhi because
the word size is 16 bits.

That is badly wrong, in fact, the whole notion of changing the names of
the routines that get built based on the word size is horribly wrong.  The
notion that we have to have IN_LIBGCC2 to defining TARGET_BLAH macros to
constants is badly wrong too.

Please revert those patches and let's start over.  Define the problem you
need to solve and let's work to a solution that actually makes sense.

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]