This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Revised patch for compare1.c test failures
- To: Richard Henderson <rth at cygnus dot com>
- Subject: Re: Revised patch for compare1.c test failures
- From: Zack Weinberg <zack at rabi dot columbia dot edu>
- Date: Wed, 05 Jan 2000 14:27:09 -0500
- cc: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>, gcc-patches at gcc dot gnu dot org
On Mon, 27 Dec 1999 14:49:59 -0800, Richard Henderson wrote:
>On Thu, Dec 23, 1999 at 01:15:18PM -0500, Zack Weinberg wrote:
>> * c-decl.c (finish_enum): Simplify code to determine minimum and
>> maximum values of the enum, and calculate the type. Remove check
>> for FUNCTION_DECLs in the values list, which cannot happen. Replace
>> the DECL_INITIAL of each enumeration constant with a copy converted
>> to the enumeration type. When updating variant types, don't bother
>> updating the type itself.
>>
>> * c-typeck.c (build_binary_op): Simplify conditional expressions
>> when weeding out spurious signed-unsigned warnings. Add new
>> spurious warning category: if the unsigned quantity is an enum
>> and its maximum value fits in signed_type(result_type). Update
>> commentary.
>> (build_conditional_expr): Warn here if one alternative is signed
>> and the other is unsigned.
>
>Ok.
I have now committed this, sorry about the delay.
zw