Re: Your proposed change to loop.c

[Mark Mitchell <mark at codesourcery dot com>]

>>>>> "Joern" == Joern Rennecke <amylaar@cygnus.co.uk> writes:

    >> I can see that this could cause general chaos.  Do I have it
    >> right so far?  Is that the bug?

    Joern> One of the bugs.

OK.  What are the others?  Is fixing this one likely to get us past
the current roadblock?  Isn't it reasonable to fix one bug at a time?

    >> If so, isn't the fix just to iterate through assigning to v->ix
    >> after the sort, instead of before?  Presumably, when we sort
    >> again a bit

    Joern> That's what my patch from last Thursday did.

    >> later, we should do this again?  I think you're suggesting
    >> something like this in your last line above, but I don't quite
    >> get what you mean.  Go slow, work with me. :-)

    Joern> No.  Getting into any more detail would mean making a
    Joern> patch, but I don't have any spare CPU cycles now to test
    Joern> it.  

Surely Cygnus has a spare machine somewhere that you could use?

You seem to fail to understand that I am volunteering my time to try
to help fix a problem that resulted from a patch that you checked in
which was apparently largely untested.  Perhaps you think that I am
dense, and unable to comprehend your straightforward patch.  If so, I
apologize, but I am the only warm body available at the moment.  

I believe it to be well understood that s/he who contributes code
implicitly agrees to help fix problems directly resulting from that
code, for some reasonable time thereafter.  Don't you agree?

So, we have a choice.  Work together and fix the problems, or, sadly,
undo your hard work of the previous week so that we can make progress.
I am very much trying to help you get your work checked in, but I need
some help from you so that I can understand what's going on.

Thanks,

--
Mark Mitchell                   mark@codesourcery.com
CodeSourcery, LLC               http://www.codesourcery.com