This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: C++ PATCH: check catch parameter


>>>>> "Nathan" == Nathan Sidwell <nathan@acm.org> writes:

    Nathan> Ok to install?

This is fine, except that you duplicated a bunch of code.  Please
break it out into something like incomplete_or_void_star_p () or
something, and put the duplicated code there.  Will improve
readability as well!

--
Mark Mitchell                   mark@codesourcery.com
CodeSourcery, LLC               http://www.codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]