This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Creating a prettier flow graph


> I want to take care of these things, and then I'll stage in the patch.
> (About 2/3 of it is basic_block_{head,end}[b] -> BLOCK_{HEAD,END} (b).)

If I may make a suggestion: could we rather use structures than macros?
I.e., the following looks much better IMHO:

struct basic_block
{
  rtx head;
  rtx end;
  /* more to be filled in as it becomes necessary.  */
};

struct basic_block **bblock;

Then, "s/basic_block_head[$1]/bblock[$1]->head/".

I think too much of the compiler is written in capital letters ;)

Bernd



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]