This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Unifying asm and normal insn handling


> 
> You should probably indicate explicitly that we fall through the case into
> the default.  Usually we mark such things with /* FALLTHROUGH */

Ok.

>   > +  /* Just return "no reloads" if insn has no operands with constraints.  */
>   > +  if (noperands == 0 || n_alternatives == 0)
>   > +    return;
> I'm not sure this is safe, believe it or not.

The previous code did this already for asm statements, and  I didn't notice
that this wasn't done for normal insns.  I'll try whether simply deleting the
condition causes any problems for asms (it shouldn't, but...)

Bernd



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]