This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: FIX_REGISTER_CHECK



  In message <199810080259.TAA13357@rtl.cygnus.com>you write:
  > The patch seems incomplete, in two different ways.
  > 1) You are adding an error message for invalid -fcall* options, but you
  >    only do so for two registers.  You don't give errors for all invalid
  >    options.
  > 2) You are adding an error message for invalid -fcall* options, but you
  >    only do so for one target.  You don't give errors for all targets.
  > Both of these problems seem undesirable to me.
  > 
  > If it is really only the stack pointer and frame pointer that you are
  > worried about at this time, then why make the patch MIPS specific?
Agreed.  In fact if we wanted a generic check for this problem, we could
probably include the argument/return registers since they can't be call-saved.



  > It would make the patch simpler to check
  > them for every target.  This would avoid the need for a new machine
  > dependent macro, and eliminates one of my objections, and gives a good
  > argument against the other.
I also would think that any machine dependent checks could be handled via
CONDITIONAL_REGISTER_USAGE, which would avoid the need for yet another macro.

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]