Re: egcs, PATCH to fix warnings in gperf generated files ...

["Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>]

 > From: Mark Mitchell <mark@markmitchell.com>
 > 
 > >>>>> "Kaveh" == Kaveh R Ghazi <ghazi@caip.rutgers.edu> writes:
 > 
 > 
 >     Kaveh> 	I disagree.  Clutter warnings distract people from
 >     Kaveh> real ones, and also encourage people to partially or
 > 
 > I understand this point.  But, fixing gperf should take all of a very
 > few minutes, if you have the source.  Somewhere, it needs to put out
 > some `0's instead of just closing curly braces, right?  Then, the
 > problem would be solved for good.  You can submit the patches to
 > Bruno, and I'm sure that the gperf patches could be made available on
 > the EGCS ftp-site.  


	Hmm...




 > I'm not quite sure as to the future of gperf; on my system it comes
 > with a `libg++-devel' package, which I didn't really want to install
 > since I'm not doing libg++ development.  Eventually, I hope it will
 > become a stand-alone tool.  Perhaps that's what Bruno will do with
 > it. 

	Version 2.7 is available as a standalone tool on prep.


 > 
 >     Kaveh> 	To the extent that I can remove clutter warnings
 >     Kaveh> without a serious technical downside, it provides value.
 >     Kaveh> My patch removes a few hundred warnings with only a couple
 >     Kaveh> of two liner patches.  So I think its well worth it.
 > 
 > But, your patches are a hack.  Editing machine-generated code is
 > tricky.  For example, a new version of gperf might change it's
 > formatting in some way that breaks your scripts.  You just can't be
 > sure.  
 > 
 > [...] (More good reasons not to use my hack.)
 > 
 > This issue is probably not worth us arguing further about; 

	Actually, you've convinced me. :-)

If the maintainers would let me make patches to gperf and we use that,
not waiting for Bruno to make another public release, I'd be happy to
go that route.  It didn't occur to me that we would use a
"non-released" version of a tool, but we do that for just about every
other infrastructure tool already. :-)

	So I'll withdraw the patch if its agreed that we can use a
patched egcs version of gperf (and I'll submit the patch to Bruno so
that the next official version will have it or something similar.)

		--Kaveh
--
Kaveh R. Ghazi			Engagement Manager / Project Services
ghazi@caip.rutgers.edu		Icon CMT Corp.