This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: egcs, more c++/g++ warning patches


 > From: Jason Merrill <jason@cygnus.com>
 > 
 > >>>>> Kaveh R Ghazi <ghazi@caip.rutgers.edu> writes:
 > 
 >  > 	* call.c (compare_ics): Initialize variables `deref_from_type2',
 >  >  	`deref_to_type1' and `deref_to_type2'.
 > 
 > I don't know that we want to change code to silence a warning that is known
 > to be broken.
 > Jason



	There are bogus warnings, and there are warnings which gcc is
*documented* as not being able to detect are unnecessary.  E.g., from
the gcc manual for -Wuninitialized:

 > ... Here is another common case:
 > 
 >   int save_y;
 >   if (change_y) save_y = y, y = new_y;
 >   ...
 >   if (change_y) y = save_y;

	I believe the warnings I fixed above are of this variety, only
a lot more complicated.  I don't believe that when gcc's flow analysis
is fixed it will affect these types, so may I install this patch?

	Also what about all the other entries in that patch, are they
okay?

		Thanks,
		--Kaveh
--
Kaveh R. Ghazi			Engagement Manager / Project Services
ghazi@caip.rutgers.edu		Icon CMT Corp.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]