This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Another paralell make patch for libf2c


> 
> 
>   In message <199810051836.OAA27859@melange.gnu.org>you write:
>   > I can't see any reason for this patch.  Could you please *explain*
>   > why the patch is needed?  The last, similar patch you submitted
>   > seemed to be not most appropriate either, as Dave Love seemed to find
>   > a more appropriate one (IIRC).  But he and I, and everyone else, can
>   > only guess, because you tend to avoid actually explaining the problem
>   > you're seeing, and how your patch fixes it.
>   > 
>   > Jeff, could you revert this most recent patch until Dave Love and/or
>   > I have at least the foggiest idea what specific problem it is trying
>   > to solve?
> I believe that by showing that s-libfoo depends on foo that each subdir
> (f77, i77, u77) can be built in parallel and that the rules to build $(LIBG2C)
> will not be issued before the makes in the subdirs are finished.
> 
> Without the dependencies nothing stops the rules for LIBG2C from being issued
> before the subdir makes are complete.  At least that's my take.

That is correct.

> 
> I can certainly revert the patch if you still desire.
> 
> jeff
> 
> ps.  I agree totally with your other comments.  Far better for HJ to explain
> the patch when he submits it instead of making us guess.
> 

I have to ask who reviewed/approved those bogus changes to g77
makefiles? It is not the first time it broke the parallel
build. Why not let someone who at least knows something about
the GNU make review the makefile changes first?


-- 
H.J. Lu (hjl@gnu.org)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]