This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: resend patch: yet another macro expansion bug (cpplib)



  In message <199810030000.UAA00298@rabi.phys.columbia.edu>you write:
  > 
  > This patch appears to have gotten lost.  It was approved conditional
  > on another patch which has been applied.
  > 
  > zw
  > 
  > 1998-10-02 19:59 -0400  Zack Weinberg  <zack@rabi.phys.columbia.edu>
  > 
  > 	* cpplib.c (macroexpand): Correct off-by-one error in handling
  > 	of escapes [fixes c-torture/compile/981001-4.c].
Installed.

Note a ChangeLog entry is merely to indicate what changed, not why.  So
there's no need/desire to mention test cases or anything like that.

If you find yourself writing those kinds of things in ChangeLog entries, then
you should go back and add comments to the source :-)  The source is where we
explain why changes were made.

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]