This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: libg++/curses fix for OSR5 committed.



  In message <35F70985.FAEC1153@datadesign.com>you write:

  > > Any chance you could add this to the standard fixincludes script?  This
  > > problem occurs on quite a few systems.
  > >
  > > Bruce, this is something we'll need the new fixinc stuff to do too.
  > 
  > Too late, methinks.  This fix has been the new fixinc since forever:
Cool.  You're already a step ahead of us.

  > This is different than the "fixinc.wrap" approach.  That approach is to
  > #define "bool" for the duration of processing the file "curses.h"
  > and then "#include_next" the original.  That approach will *fail* if
  > there are other fixes that need to be applied to "curses.h" because
  > it uses a fixed-contentent wrapper file that would displace any other
  > applied fixes.  This approach merely disables #define-d and typedef-ed
  > remappings of "bool" for __cplusplus compiles.
Yes, wrapping fails for many cases.  It has advantages when we can
make it work though.

Wrapping probably isn't the right thing to do in general.  In fact
I suspect it's the wrong thing to do for the general fixincludes/fixinc
scripts since they are designed to work on many systems and those
systems are the ones most likely to need additional curses.h fixing.

Thanks,
jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]