Re: PATCH for static DWARF2 buffers

[Mark Mitchell <mark at markmitchell dot com>]

>>>>> "Jim" == Jim Wilson <wilson@cygnus.com> writes:

    Jim> The patch looks OK to me.

Thanks for looking at it.

    Jim> I noticed that you have a tendency to use `char* foo', but
    Jim> most GNU code uses `char *foo'.

I never declare multiple variables on a single line (e.g. `char *foo,
bar;') which, I believe, is the motivation for using the (IMO
harder-to-read) `char *foo'.  Still, I'm happy to make those changes,
before checking in the change, if you'd like.  Would you?
 
    Jim> original author of this code thought it would be better to
    Jim> just convert the address constants to strings and save the
    Jim> strings in permanent (xmalloced) memory.  There may be better
    Jim> ways to do this.  

Agreed.  But, for the time being at least, we'll have fixed the
problem.  Would you like me to put this change on the 1.1 branch as
well as the mainline?  (I have no strong feelings about this
question.)

-- 
Mark Mitchell 			mark@markmitchell.com
Mark Mitchell Consulting	http://www.markmitchell.com