This is the mail archive of the
mailing list for the GCC project.
Re: A new patch for the x86 -fpic and -fomit-frame-pointer bug
- To: hjl at lucon dot org (H.J. Lu)
- Subject: Re: A new patch for the x86 -fpic and -fomit-frame-pointer bug
- From: Jeffrey A Law <law at cygnus dot com>
- Date: Sun, 26 Jul 1998 01:36:26 -0600
- cc: manfred at s-direktnet dot de, egcs-patches at cygnus dot com
- Reply-To: law at cygnus dot com
In message <m0yvqx5-000266C@ocean.lucon.org>you write:
> Here is a new patch for
> My previous one
> is incorrect. This one seems to work. The problem is reg-stack.c will
> generate insn to load 0 into a fp register.
> # grep CONST0_RTX reg-stack.c
> will show that.
> H.J. Lu (email@example.com)
> Mon Jul 13 08:36:01 1998 H.J. Lu (firstname.lastname@example.org)
> * config/i386/i386.h (CONST_DOUBLE_OK_FOR_LETTER_P): Return 0
> for PIC if reload is not completed yet.
You should have added some comments in the code about why the change
was made in the code. This should be standard operating procedure
for complex bugs.
The idea is someone should be able to look at that code and know exactly
why it is rejecting constants in some cases. I've added some comments
to help clarify why this change was needed.
I also changed the code to allow the constants when not eliminating
the frame pointer, which should be safe.
I've installed the updated patch on the egcs-1.1 branch as well as
in the mainline sources.
Manfred -- can you try your aggressive build & test cycle to verify
that the problem has indeed been fixed and that others have not crept