[Bug c/20385] Lame parse error message for undefined type

["egallager at gcc dot gnu.org" <gcc-bugzilla at gcc dot gnu dot org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=20385

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |egallager at gcc dot gnu.org

--- Comment #11 from Eric Gallager <egallager at gcc dot gnu.org> ---
(In reply to Paolo Bonzini from comment #10)
> Author: bonzini
> Date: Fri Dec 17 21:23:36 2010
> New Revision: 167999
> 
> URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=167999
> Log:
> gcc:
> 2010-12-17  Paolo Bonzini  <bonzini@gnu.org>
> 
> 	PR c/20385
> 	* function.c (used_types_insert): Handle ERROR_MARK.
> 	* c-decl.c (grokdeclarator): Handle ERROR_MARK.
> 	(declspecs_add_type): Leave error_mark_node in specs->type.
> 	(finish_declspecs): Change it to integer_type_node here.
> 	* c-parser.c (c_parser_peek_2nd_token): Move earlier.
> 	(enum c_lookahead_kind): New.
> 	(c_parser_next_token_starts_typename): New name of
> 	c_parser_next_tokens_start_typename.  Accept lookahead enum
> 	and handle it here instead of...
> 	(c_parser_next_tokens_start_declaration): ... here.  Call it.
> 	(c_parser_declspecs): Accept another argument.  Do not exit
> 	on C_ID_ID if it is guessed to be an unknown typename.
> 	(c_parser_parms_declarator): Use 2nd token to distinguish a K&R
> 	declaration from an ANSI declaration starting with an unknown
> 	typename.
> 	(c_parser_struct_declaration, c_parser_objc_type_name,
> 	c_parser_typeof_specifier, c_parser_declarator,
> 	c_parser_direct_declarator_inner): Adjust calls.
> 	(c_parser_parameter_declaration): Likewise.
> 	(c_parser_type_name): Pass back an error_mark_node to the caller.
> 	(c_parser_postfix_expression): Do error recovery when 
> 	c_parser_type_name returns NULL.
> 
> testsuite:
> 2010-12-17  Paolo Bonzini  <bonzini@gnu.org>
> 
> 	PR c/20385
> 	* objc.dg/tls/init-2.m: Adjust.
> 	* gcc.dg/noncompile/920923-1.c: Adjust.
> 	* gcc.dg/noncompile/pr44517.c: Adjust.
> 	* gcc.dg/declspec-18.c: New test.
> 
> 
> Added:
>     trunk/gcc/testsuite/gcc.dg/declspec-18.c
> Modified:
>     trunk/gcc/ChangeLog
>     trunk/gcc/c-decl.c
>     trunk/gcc/c-parser.c
>     trunk/gcc/function.c
>     trunk/gcc/testsuite/ChangeLog
>     trunk/gcc/testsuite/gcc.dg/noncompile/920923-1.c
>     trunk/gcc/testsuite/gcc.dg/noncompile/pr44517.c
>     trunk/gcc/testsuite/objc.dg/tls/init-2.m

So can this be closed as FIXED now then?