[Bug c/54381] -Wsizeof-pointer-memaccess refers to "destination" for strncmp

["jakub at gcc dot gnu.org" <gcc-bugzilla at gcc dot gnu dot org>]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54381

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-10-12 18:23:13 UTC ---
Author: jakub
Date: Fri Oct 12 18:23:03 2012
New Revision: 192406

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=192406
Log:
    PR c/54381
    * c-common.h (sizeof_pointer_memaccess_warning): Adjust prototype.
    * c-common.c (sizeof_pointer_memaccess_warning): Take array of 3
    locs and array of 3 trees instead of just single loc and single
    sizeof_arg tree.  Handle __builtin___*_chk builtins too, and
    also stpncpy, bcopy, bcmp, bzero, snprintf and vsnprintf builtins.
    For *cmp* builtins that take two sources strings report warnings
    about first and second source, not about destination and source.

    * c-parser.c (struct c_tree_loc_pair): Removed.
    (c_parser_expr_list): Remove struct c_tree_loc_pair * argument,
    add location_t * and tree * arguments, fill in array of 3
    sizeof_arg trees and corresponding locs.
    (c_parser_attributes, c_parser_objc_keywordexpr): Adjust
    c_parser_expr_list callers.
    (c_parser_postfix_expression_after_primary): Likewise.  Pass
    array of 3 sizeof_arg trees and locs (corresponding to first
    3 arguments) to sizeof_pointer_memaccess_warning.

    * semantics.c (finish_call_expr): Pass array of 3 sizeof_arg
    trees and locs (corresponding to first 3 arguments) to
    sizeof_pointer_memaccess_warning.

    * c-c++-common/Wsizeof-pointer-memaccess1.c: New test.
    * c-c++-common/Wsizeof-pointer-memaccess2.c: New test.
    * gcc.dg/Wsizeof-pointer-memaccess1.c: New test.
    * gcc.dg/torture/Wsizeof-pointer-memaccess1.c: Test also stpncpy.
    Adjust expected wording of warnings for *cmp* builtins.
    * g++.dg/torture/Wsizeof-pointer-memaccess1.C: Likewise.
    * g++.dg/torture/Wsizeof-pointer-memaccess2.C: Likewise.

Added:
    trunk/gcc/testsuite/c-c++-common/Wsizeof-pointer-memaccess1.c
    trunk/gcc/testsuite/c-c++-common/Wsizeof-pointer-memaccess2.c
    trunk/gcc/testsuite/gcc.dg/Wsizeof-pointer-memaccess1.c
Modified:
    trunk/gcc/c-family/ChangeLog
    trunk/gcc/c-family/c-common.c
    trunk/gcc/c-family/c-common.h
    trunk/gcc/c/ChangeLog
    trunk/gcc/c/c-parser.c
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/semantics.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/torture/Wsizeof-pointer-memaccess1.C
    trunk/gcc/testsuite/g++.dg/torture/Wsizeof-pointer-memaccess2.C
    trunk/gcc/testsuite/gcc.dg/torture/Wsizeof-pointer-memaccess1.c