This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
[Bug libstdc++/51965] Redundant move constructions in heap algorithms
- From: "marc.glisse at normalesup dot org" <gcc-bugzilla at gcc dot gnu dot org>
- To: gcc-bugs at gcc dot gnu dot org
- Date: Tue, 24 Jan 2012 10:49:38 +0000
- Subject: [Bug libstdc++/51965] Redundant move constructions in heap algorithms
- Auto-submitted: auto-generated
- References: <bug-51965-4@http.gcc.gnu.org/bugzilla/>
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51965
--- Comment #7 from Marc Glisse <marc.glisse at normalesup dot org> 2012-01-24 10:49:38 UTC ---
(In reply to comment #6)
> But __pop_heap doesn't seem so straightforward to tweak, we also changed
> a bit the interfaces.
At first glance, I am not sure why pop_heap can end up calling push_heap, so I
would need to really look at the code (no time...).
> Marc can you submit a complete patch?
Not now, sorry. Maybe in a few weeks... (no promise)
I haven't reviewed Aliaksandr's patch, but the approach seems sensible.
> Otherwise, so close to the branch for 4.7.0 I'm not sure I will be able to work on this,
It may be safer to patch it in 4.8.0 and backport to 4.7.1.