[Bug c/51391] Differences between setting Winline in command-line and through pragma GCC diagnostic

["rguenth at gcc dot gnu.org" <gcc-bugzilla at gcc dot gnu dot org>]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51391

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu.org,
                   |                            |jsm28 at gcc dot gnu.org
           Severity|normal                      |enhancement

--- Comment #16 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-12-05 09:49:20 UTC ---
I think a more appropriate "fix" today is to drop the x_flag_no_inline
setting (it should not be necessary these days) but keep ignoring
-Winline at -O0 (there is probably a better central place to do this,
supposedly at the point we emit the warning, instead of in the option
code).  In fact, the warning

inlineBug.h:16:8: warning: function âinlineBug::inlineBug()â can never be
inlined because it is suppressed using -fno-inline

does not seem useful to me at all (see tree-inline.c:tree_inlinable_function_p,
warning in a predicate seems questionable to me at best, warning during
expand_call_inline isn't better either.  A pass over remaining inline-declared
edges after IPA inline transform sounds more appropriate to me, also enabled
when IPA inline is disabled itself)