This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
[Bug target/49263] SH Target: underutilized "TST #imm, R0" instruction
- From: "kkojima at gcc dot gnu.org" <gcc-bugzilla at gcc dot gnu dot org>
- To: gcc-bugs at gcc dot gnu dot org
- Date: Fri, 14 Oct 2011 23:06:06 +0000
- Subject: [Bug target/49263] SH Target: underutilized "TST #imm, R0" instruction
- Auto-submitted: auto-generated
- References: <bug-49263-4@http.gcc.gnu.org/bugzilla/>
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49263
--- Comment #12 from Kazumoto Kojima <kkojima at gcc dot gnu.org> 2011-10-14 23:06:06 UTC ---
(In reply to comment #11)
> Created attachment 25491 [details]
> Proposed patch including test case
Looks fine. A very minor style nits:
> + if (GET_CODE (XEXP (x, 0)) == AND /* tst instruction. */
This comment looks a bit bogus. A full sentence comment would
be better.
> +
> +
There are some extra empty lines. GNU/GCC coding style says
that only one empty line is needed. I know that there are
extra empty lines already, but we should not add new ones :-)