[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Ada bootstrap

["ebotcazou at gcc dot gnu dot org" <gcc-bugzilla at gcc dot gnu dot org>]

------- Comment #14 from ebotcazou at gcc dot gnu dot org  2010-01-15 08:27 -------
> sorry for replying late, I was missed this problem somehow in my bugzilla
> folder. The test in question verify that variables that are common or weak are
> also either public or external.

No doubt about that.  The problem is, this was installed without mention in the
ChangeLog so looks quite unintentional.  If this is intentional, you should fix
the ChangeLog.

> I will have time to try to reproduce the problem only tomorrow or during
> weekend (it will be bit tricky as I know of no machine known to fail here I
> can access easily),

Please read comment #5.

> but it seems to me that if Ada produce variable failing this test, it is
> frontend problem uncovered by the sanity check.

See utils.c:create_var_decl_1

  /* Ada doesn't feature Fortran-like COMMON variables so we shouldn't
     try to fiddle with DECL_COMMON.  However, on platforms that don't
     support global BSS sections, uninitialized global variables would
     go in DATA instead, thus increasing the size of the executable.  */
  if (!flag_no_common
      && TREE_CODE (var_decl) == VAR_DECL
      && !have_global_bss_p ())
    DECL_COMMON (var_decl) = 1;


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068