This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
[Bug target/38781] PR38151: valgrind finds problem
- From: "dcb314 at hotmail dot com" <gcc-bugzilla at gcc dot gnu dot org>
- To: gcc-bugs at gcc dot gnu dot org
- Date: 15 Jan 2009 21:51:04 -0000
- Subject: [Bug target/38781] PR38151: valgrind finds problem
- References: <bug-38781-9596@http.gcc.gnu.org/bugzilla/>
- Reply-to: gcc-bugzilla at gcc dot gnu dot org
------- Comment #4 from dcb314 at hotmail dot com 2009-01-15 21:51 -------
(In reply to comment #3)
> An updated patch is at
>
> http://gcc.gnu.org/ml/gcc-patches/2009-01/msg00747.html
I have a couple of minor questions about the coding style
of this patch.
1. Why is the "/ 8 / 8" a good idea ?
Presumably "/ 64" doesn't do it right ?
2. On the middle condition of the for-loop, could it
be micro-optimised to compute the upper limit of the
for loop before the loop starts ?
For example, instead of
; (i < A) && (i + pos) < B; ++i
replace with
const int limit = min( A, B - pos);
...
; i < limit; ++i
Just an idea.
--
dcb314 at hotmail dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcb314 at hotmail dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38781