[Bug libgomp/32193] Upgrading GNU/Linux to libc6_2.6~20070518-2 breaks libgomp make - FIX given

["rob1weld at aol dot com" <gcc-bugzilla at gcc dot gnu dot org>]

------- Comment #2 from rob1weld at aol dot com  2007-06-03 12:16 -------
>> Comment From Andrew Pinski
>> That is wrong and non portable.

Your answer seems simple enough but I'm not sure I understand it ...


I just did a "make -i check" and diff on my prior compile and this one.

The results of the check tests are _identical_. Is the testing incomplete?

                === libgomp tests ===
Running target unix
                === libgomp Summary ===
# of expected passes            1566


All the tests passed. It gets no better than that.

I suggest that it is not "wrong" - as for "portable", I can't write code for
computers I know nothing about. Can you tell me how the description below is
not portable for YOU. It would not make any changes for you, would it?


It is correct and portable to the extent that it can be to:

1) Have the configure script check for the target "i686-pc-linux-gnu" and then
run the snippet of code I provided above (it is the standard way according to
the author of lib6).

2) If the library is NEW then have configure define something "similar" to:
#define HAVE_libc6_2_6_PTHREAD_AFFINITY_NP 1 the the file
gcc-4_3-trunk/libgomp/config.h .

3): In file gcc-4_3-trunk/libgomp/libgomp.h have something "similar" to this:

#ifdef HAVE_libc6_2_6_PTHREAD_AFFINITY_NP
#include <nptl/pthread.h>
#else
#include <pthread.h>
#endif

Whats wrong with that ?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32193