[Bug bootstrap/30541] Top-level should pass GNATBIND, GNATLINK and GNATMAKE variables down

["bonzini at gnu dot org" <gcc-bugzilla at gcc dot gnu dot org>]

------- Comment #5 from bonzini at gnu dot org  2007-01-22 16:48 -------

> During the build we still call (and require) a 'gnatmake' in $PATH like for
> 
>   (cd ada/bldtools/nmake_b; gnatmake -q xnmake ; ./xnmake -b ../../nmake.adb )
> 
> but at least gnatbind is used as specified at configure time (for building
> stage1).  Somebody might want to fix gnatmake in a similar way.

Hi Richard.

Here's a quick patch review.  First of all, the changes need to affect also
GNATBIND and GNATLINK.

Second, it's better if you add a line like this:

flags_to_pass = { flag= GNATBIND ; };

in Makefile.def rather than modifying EXTRA_GCC_FLAGS in Makefile.tpl.

Third, for 4.3, the gcc/Makefile.in changes are not necessary.  This patch is
not a regression, so ask the Ada maintainers if they want it in 4.1 and 4.2
after one or two weeks in 4.3.

Finally, the only appearance of gnatbind/gnatmake/gnatlink (instead of the
variables) is the one you found in ada/Make-lang.in, and it makes sense to fix
it too.

Thanks for the work,


-- 

bonzini at gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-01-22 16:48:47
               date|                            |
            Summary|Ada bootstrap fails, stage1 |Top-level should pass
                   |binding does not honor      |GNATBIND, GNATLINK and
                   |GNATBIND                    |GNATMAKE variables down


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30541