This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
[Bug libfortran/22217] Z edit descriptor with negative numbers
- From: "fxcoudert at gcc dot gnu dot org" <gcc-bugzilla at gcc dot gnu dot org>
- To: gcc-bugs at gcc dot gnu dot org
- Date: 5 Jul 2005 07:52:46 -0000
- Subject: [Bug libfortran/22217] Z edit descriptor with negative numbers
- References: <20050628134513.22217.tkoenig@gcc.gnu.org>
- Reply-to: gcc-bugzilla at gcc dot gnu dot org
------- Additional Comments From fxcoudert at gcc dot gnu dot org 2005-07-05 07:52 -------
For the GFC_LARGEST_INTEGER_KIND macro, there is already a GFC_INTEGER_LARGEST.
Or do you mean that GFC_LARGEST_INTEGER_KIND should be just 8 (or 16), not
GFC_INTEGER_8 (or GFC_INTEGER_16)?
As for this bug, the solution you mention was the one I thought of, but it means
changing prototypes. A better solution (at least, I think it is better) is to
have an extract_uint() function that does cast to GFC_UINTEGER_4 before casting
to GFC_UINTEGER_LARGEST.
Attached patch fixes the problem (for Z, O and B edit descriptors, with all kinds).
I'm leaving town tomorrow, won't have access to an internet connection and lots
of things to do before tomorrow. So, please feel free to test and commit this
patch! If nobody does it, I'll do it when I come back (in August).
--
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |patch
Last reconfirmed|2005-06-29 20:53:37 |2005-07-05 07:52:45
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22217