This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug libgcj/13720] gcc/libjava/java/lang/natSystem.cc: syntax error using "unsigned jint"


------- Additional Comments From tromey at gcc dot gnu dot org  2004-09-22 21:50 -------
A couple notes on this patch.

First, we don't support compiling libgcj with a different
version of gcj other than the one it comes with.  The reason
for this is that gcj and libgcj are tightly coupled; for instance
gcj and libgcj both have information about the exact format of
java.lang.Class.

Second, I'm not sure this patch is correct.  E.g.,

+      || src_offset - (-count) >= 0 // check for possible integer overflow

Suppose src_offset==10 and count==3.
Then src_offset-(-count) == 7, which is >= 0,
but no integer overflow has occurred.
(This is a perfectly valid situation if the source
array's length is >= 13)

So, I'm closing this and not checking in the patch.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13720


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]