[Bug optimization/11386] GNU Emacs 21.3 failed to install using GCC 3.3, but GCC 3.2.3 works.

["ebotcazou at gcc dot gnu dot org" <gcc-bugzilla at gcc dot gnu dot org>]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11386


ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |INVALID


------- Additional Comments From ebotcazou at gcc dot gnu dot org  2003-07-11 17:48 -------
The problem is the declaration:
static Boolean actions_initted = False;

According to Paul, Emacs makes assumptions about which section the variable will
be put in and this doesn't work anymore with GCC 3.3.

The following patch fixes the problem:


2003-07-11  Eric Botcazou <ebotcazou@libertysurf.fr>

	lwlib/lwlib-Xaw.c (actions_initted): Rename into
	actions_need_init and initialize to True.
	(make_dialog): Use actions_need_init instead of
	actions_initted.

--- lwlib-Xaw.c.orig    Fri Jul 11 19:40:07 2003
+++ lwlib-Xaw.c Fri Jul 11 19:41:04 2003
@@ -270,7 +270,7 @@ static void wm_delete_window();
 static XtActionsRec xaw_actions [] = {
   {"lwlib_delete_dialog", wm_delete_window}
 };
-static Boolean actions_initted = False;
+static Boolean actions_need_init = True;

 static Widget
 make_dialog (name, parent, pop_up_p, shell_title, icon_name, text_input_slot,
radio_box, list, left_buttons, right_buttons)
@@ -299,12 +299,12 @@ make_dialog (name, parent, pop_up_p, she
   if (radio_box) abort (); /* not implemented */
   if (list) abort (); /* not implemented */

-  if (! actions_initted)
+  if (actions_need_init)
     {
       XtAppContext app = XtWidgetToApplicationContext (parent);
       XtAppAddActions (app, xaw_actions,
                       sizeof (xaw_actions) / sizeof (xaw_actions[0]));
-      actions_initted = True;
+      actions_need_init = False;
     }

   override = XtParseTranslationTable (overrideTrans);