Re: i386-elf does not build on 3.3 branch

[Joel Sherrill <joel dot sherrill at OARcorp dot com>]

Jan Hubicka wrote:
> 
> >
> >
> > gcc -c   -g -O2 -DIN_GCC -DCROSS_COMPILE  -W -Wall -Wwrite-strings
> > -Wstrict-prototypes -Wmissing-prototypes -Wtraditional -pedantic
> > -Wno-long-long   -DHAVE_CONFIG_H    -I. -I. -I../../gcc-3.3-branch/gcc
> > -I../../gcc-3.3-branch/gcc/. -I../../gcc-3.3-branch/gcc/config
> > -I../../gcc-3.3-branch/gcc/../include \
> >         ../../gcc-3.3-branch/gcc/config/i386/i386.c -o i386.o
> > ../../gcc-3.3-branch/gcc/config/i386/i386.c: In function
> > `override_options':
> > ../../gcc-3.3-branch/gcc/config/i386/i386.c:1025:
> > `DEFAULT_PCC_STRUCT_RETURN' undeclared (first use in this function)
> > ../../gcc-3.3-branch/gcc/config/i386/i386.c:1025: (Each undeclared
> > identifier is reported only once
> > ../../gcc-3.3-branch/gcc/config/i386/i386.c:1025: for each function it
> > appears in.)
> > make[1]: *** [i386.o] Error 1
> >
> >
> > I am assuming this is a side-effect of something or a lot of popular
> > targets
> > wouldn't compile either.  As best I can tell, i386/i386elf.h should have
> > this:
> >
> > /* The SVR4 ABI for the i386 says that records and unions are returned
> >    in memory.  */
> > #undef DEFAULT_PCC_STRUCT_RETURN
> > #define DEFAULT_PCC_STRUCT_RETURN 1
> >
> > Since most of the other ELF targets do this.  Is this the right fix?
> > I can file a PR if it is necessary.
> 
> Or alternatively you can use my patch I sent some time ago to make
> DEFAULT_PCC_STRUCT_RETURN default to 1 in i386.c
> It has not been reviewed yet, so I didn't applied it.

Richard, which would you rather see?    I have added the above lines to
my local
i386elf.h and has built way past this point but isn't finished yet.

Jan, does your patch remove the setting of DEFAULT_PCC_STRUCT_RETURN
in the files which set it to 1 anyway?  If so, then I would lean to just 
adding these lines on the 3.3-branch.  But it is Richard's call.

> Honza
> >
> > --joel sherrill