This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
Re: libstdc++/8463: std::ios_base has a non-virtual destructor
- From: bkoz at gcc dot gnu dot org
- To: bkoz at gcc dot gnu dot org, gcc-bugs at gcc dot gnu dot org, gcc-prs at gcc dot gnu dot org, john_maddock at compuserve dot com, nobody at gcc dot gnu dot org
- Date: 5 Nov 2002 16:29:47 -0000
- Subject: Re: libstdc++/8463: std::ios_base has a non-virtual destructor
- Reply-to: bkoz at gcc dot gnu dot org, bkoz at gcc dot gnu dot org, gcc-bugs at gcc dot gnu dot org, gcc-prs at gcc dot gnu dot org, john_maddock at compuserve dot com, nobody at gcc dot gnu dot org, gcc-gnats at gcc dot gnu dot org
Synopsis: std::ios_base has a non-virtual destructor
Responsible-Changed-From-To: unassigned->bkoz
Responsible-Changed-By: bkoz
Responsible-Changed-When: Tue Nov 5 08:29:46 2002
Responsible-Changed-Why:
Mine.
State-Changed-From-To: open->feedback
State-Changed-By: bkoz
State-Changed-When: Tue Nov 5 08:29:46 2002
State-Changed-Why:
You are correct.
2002-11-05 Benjamin Kosnik <bkoz@redhat.com> PR libstdc++/8463 * include/bits/ios_base.h (~ios_base): Make virtual. Index: include/bits/ios_base.h =================================================================== RCS file: /cvs/gcc/gcc/libstdc++-v3/include/bits/ios_base.h,v retrieving revision 1.19 diff -c -p -r1.19 ios_base.h *** include/bits/ios_base.h 24 Jul 2002 23:17:12 -0000 1.19 --- include/bits/ios_base.h 5 Nov 2002 16:26:39 -0000 *************** namespace std *** 414,420 **** } // Destructor ! ~ios_base(); protected: ios_base(); --- 414,420 ---- } // Destructor ! virtual ~ios_base(); protected: ios_base();
Sadly, this cannot be applied to the gcc-3_2-branch at the moment as it changes the libstdc++ ABI.
-benjamin
http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=8463