This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: QMTest patch broke bootstrap in objdir with colon in name




--On Wednesday, June 19, 2002 12:38:16 AM +0200 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> wrote:


Mark,

I just noticed that this patch

2002-05-19  Mark Mitchell  <mitchell@doubledemon.codesourcery.com>

	* Makefile.in (distclean): Remove QMTest stuff.
	(QMTEST_PATH): New variable.
	(QMTESTFLAGS): Likewise.
	(QMTESTRUNFLAGS): Likewise.
	(QMTEST): Likewise.
	(QMTEST_GPP_TESTS): Likewise.
	(QMTEST_DIR): Likewise.
	(QMTEST_DIR/context): New target.
	(qmtest-g++): Likeise.
	(qmtest-gui): Likewise.
	(QMTEST_DIR/gpp-expected.qmr): Likewise.

broke bootstrap if the objdir contains a colon in it's name: GNU make 3.79
complains:
Thank you for letting me know about that.

As a quick hack, I've removed the ${objdir}/ part from the generated
Makefile to allow the bootstrap to continue.  This may even be the correct
fix.
I believe you are correct.  I'm not sure why I had the more verbose
version in there.  In any case, I've checked in the attached patch.

Tested on i686-pc-linux-gnu by building in an objdir with a colon in its
name; committed on the mainline.

--
Mark Mitchell                mark@codesourcery.com
CodeSourcery, LLC            http://www.codesourcery.com

2002-06-19  Mark Mitchell  <mark@codesourcery.com>

	* Makefile.in (QMTEST_DIR): Simplify definition.

Index: Makefile.in
===================================================================
RCS file: /cvs/gcc/gcc/gcc/Makefile.in,v
retrieving revision 1.901
diff -c -p -r1.901 Makefile.in
*** Makefile.in	15 Jun 2002 17:31:25 -0000	1.901
--- Makefile.in	19 Jun 2002 16:04:58 -0000
*************** QMTEST_GPP_TESTS=gpp
*** 3136,3142 ****
 # The subdirectory of the OBJDIR that will be used to store the QMTest
 # test database configuration and that will be used for temporary
 # scratch space during QMTest's execution.
! QMTEST_DIR=${objdir}/qmtestsuite

 # Create the QMTest database configuration.
 ${QMTEST_DIR} stamp-qmtest:
--- 3136,3142 ----
 # The subdirectory of the OBJDIR that will be used to store the QMTest
 # test database configuration and that will be used for temporary
 # scratch space during QMTest's execution.
! QMTEST_DIR=qmtestsuite

 # Create the QMTest database configuration.
 ${QMTEST_DIR} stamp-qmtest:


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]