This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Missing functionality in arm_compute_initial_elimination_offset


> Hi Richard,
> 
> : arm_compute_initial_elimination_offset currently contains the comment
> : 
> :   /* FIXME: we should allow for saved floating point registers.  */
> : 
> : This omission will break arm/linux compilations (amongst others)
> : which use  this option.
> : 
> : I really don't think this patch should have been installed with this 
> : important functionality missing.
> 
> Well this functionality was missing in the macro version that this
> function replaced too, so it has basically been in there forever.

No it wasn't:


          for (regno = FIRST_ARM_FP_REGNUM;                             \
               regno <= LAST_ARM_FP_REGNUM; regno++)                    \
            if (regs_ever_live[regno] && ! call_used_regs[regno])       \
              offset += 12;                                             \

This code is entirely missing from the new version.

Also, I can't find this patch on gcc-patches.  When was it posted?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]