This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: GNU GCC's f77 [tempnam -> mkstemp; proposed patch]

To: Toon Moene <toon at moene dot indiv dot nluug dot nl>
Subject: Re: GNU GCC's f77 [tempnam -> mkstemp; proposed patch]
From: Richard Henderson <rth at redhat dot com>
Date: Tue, 14 Nov 2000 14:52:06 -0800
Cc: Zack Weinberg <zackw at stanford dot edu>, Murakami Hiroshi <murakami at tmca dot ac dot jp>, bug-gcc at gnu dot org, gcc-patches at gcc dot gnu dot org
References: <20001001141745.38676.qmail@amdk6.honkan3.tmca.ac.jp> <3A105663.60E6126A@moene.indiv.nluug.nl> <20001113143645.N235@wolery.stanford.edu> <3A11B1E1.D47852CD@moene.indiv.nluug.nl>

On Tue, Nov 14, 2000 at 10:42:57PM +0100, Toon Moene wrote:
> If noone shoots a hole in this update before tomorrow 18 UTC, I'll apply
> the patch:

Well, I don't see anything wrong with the patch itself.  But
looking at the surrounding code I'd say it's pointless.  If
you go and close the file immediately, and re-open it by name
you've just obviated all the benefit of using mkstemp.

Really, that code is so ugly as to be practially unsalvagable.

r~

Follow-Ups:
- Re: GNU GCC's f77 [tempnam -> mkstemp; proposed patch]
  - From: Zack Weinberg

References:
- Re: GNU GCC's f77
  - From: Toon Moene
- Re: GNU GCC's f77
  - From: Zack Weinberg
- Re: GNU GCC's f77 [tempnam -> mkstemp; proposed patch]
  - From: Toon Moene

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]