This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: cpp0 misbehavior?


On Wed, Aug 16, 2000 at 02:31:08PM -0300, Alexandre Oliva wrote:
> On Aug 16, 2000, "Dennis I. Chernoivanov" <cdi@sparc.spb.su> wrote:
> 
> > I made a patch that works for me -- it's in attachment.
> 
> Thanks.  Please post it to gcc-patches@gcc.gnu.org, along with a
> ChangeLog entry.  Not everybody who reviews/installs patches reads
> gcc-bugs.

... although in this case, I do.  :)

Unfortunately I'm not available to review patches at the moment.  My
casual opinion is that the patch is correct in so far as it goes, but
I think you've missed some places in cppmain.c where parse_out.lineno
needs to get bumped.  It should be bumped after every call to
cpp_printf() that doesn't generate a linemarker.  [Linemarkers are the

# 123 "foo.c" ...

thingies.]

Please check all that, write and insert test cases for the bugs (in
gcc.dg/cpp), run a complete bootstrap and the test suite, then post a
revised patch to gcc-patches.  Please cc: me directly when you post
the revised patch, so I don't lose it.

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]