This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
Re: (i386-linux x sh-elf) build breakage
On Tue, Jul 25, 2000 at 10:55:36PM -0300, Alexandre Oliva wrote:
> I wanted to completely abstract away its type, so that it could be
> changed to something else in a single place.
There's not enough abstraction here to make it worth the ugliness.
You might as well not put all this widgetry in insn-attr.h at all.
Which, now that I think about it, is silly.
> Since it would have been an error to do it after insn_addresses is
> constructed, I thought it would be fine. Maybe I should add one
> argument to INSN_ADDRESSES_PUSH, with the UID of the new insn (or the
> insn itself). The idea is to help catching as soon as possible the
> creation of insns without additions to INSN_ADDRESSES.
The problem here is with insns that get emitted into sequences
that are discarded, or have their patterns re-emitted into new
insns. In such a way you get perfectly legitimate gaps in the
UID sequence.
> With these corrections, ok to install?
Probably. Let's see it again.
r~