This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
Re: nls patches - need help with make machinery
- To: dave at hiauly1 dot hia dot nrc dot ca, martin at loewis dot home dot cs dot tu-berlin dot de
- Subject: Re: nls patches - need help with make machinery
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Date: Mon, 5 Jun 2000 15:52:06 -0400 (EDT)
- Cc: gcc-bugs at gcc dot gnu dot org
> From: "John David Anglin" <dave@hiauly1.hia.nrc.ca>
>
> > > The only one that I am aware of is the "inline" keyword in couple of headers.
> > > I enclose below the log of building libintl yesterday. I had patched
> > > gettextP.h to remove the inline keyword but not hash-string.h.
> >
> > Removing it is the wrong solution. Instead, the package including intl
> > should use AC_C_INLINE in its configure.in. That will add
> >
> > #define inline
> >
> > to config.h if the compiler does not support the keyword. No changes
> > to the source code should be required.
>
> Yes, this is a much better solution and would in fact have not appeared if
> -DIN_GCC was used in the CFLAGS used for building libintl. However,
> this raises the issue that configure should possibly be run again after
> stage 1.
> Dave
This is already handled without rerunning configure in gansidecl.h
(which gcc's config.h includes.)
We can get gcc's config.h usable by intl as described here:
http://gcc.gnu.org/ml/gcc-patches/2000-06/msg00131.html
I think if we do this then everything will be fine.
--Kaveh
--
Kaveh R. Ghazi Engagement Manager / Project Services
ghazi@caip.rutgers.edu Qwest Internet Solutions