This is the mail archive of the
gcc-bugs@gcc.gnu.org
mailing list for the GCC project.
Re: nls patches - need help with make machinery
- To: martin at loewis dot home dot cs dot tu-berlin dot de (Martin v. Loewis)
- Subject: Re: nls patches - need help with make machinery
- From: "John David Anglin" <dave at hiauly1 dot hia dot nrc dot ca>
- Date: Mon, 5 Jun 2000 15:04:20 -0400 (EDT)
- Cc: gcc-bugs at gcc dot gnu dot org
> > The only one that I am aware of is the "inline" keyword in couple of headers.
> > I enclose below the log of building libintl yesterday. I had patched
> > gettextP.h to remove the inline keyword but not hash-string.h.
>
> Removing it is the wrong solution. Instead, the package including intl
> should use AC_C_INLINE in its configure.in. That will add
>
> #define inline
>
> to config.h if the compiler does not support the keyword. No changes
> to the source code should be required.
Yes, this is a much better solution and would in fact have not appeared if
-DIN_GCC was used in the CFLAGS used for building libintl. However,
this raises the issue that configure should possibly be run again after
stage 1.
Dave
--
J. David Anglin dave.anglin@nrc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6605)